lint generated launch files #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -190,6 +194,13 @@ if(BUILD_TESTING) | |||
| endif() | |||
|
|
|||
| call_for_each_rmw_implementation(tests) | |||
|
|
|||
| find_package(ament_cmake_flake8 REQUIRED) | |||
There was a problem hiding this comment.
is this necessary ? this package already find_package the ament_lint_auto dependencies.
If we want the ability to make some of them REQUIRED we could implement something similar to ament/ament_cmake#93 in ament_lint_auto and just pass ament_cmake_flake8 as a required dependency
There was a problem hiding this comment.
I am just applying "find what you need". Since the code is using a CMake function of that package it is finding it explicitly.
|
Waiting for review. |
wjwwood
approved these changes
Oct 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up of #157 (comment)
This patch shows how to lint generated files. It does so only for the composition package. Other packages should probably use something similar.